[FFmpeg-devel] [PATCH 04/12] swscale/internal: swap SWS_DITHER_NONE and SWS_DITHER_AUTO

Niklas Haas ffmpeg at haasn.xyz
Mon Oct 7 21:09:19 EEST 2024


On Mon, 07 Oct 2024 20:03:06 +0200 Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Mon, Oct 07, 2024 at 06:47:24PM +0200, Niklas Haas wrote:
> > On Mon, 07 Oct 2024 00:15:32 +0200 Michael Niedermayer <michael at niedermayer.cc> wrote:
> > > On Sat, Oct 05, 2024 at 09:23:55PM +0200, Niklas Haas wrote:
> > > > From: Niklas Haas <git at haasn.dev>
> > > >
> > > > This is done for consistency with the other public enums which will be
> > > > added in the upcoming swscale API refactor. I went through the code and checked
> > > > carefully that the value of `dither` is never implicitly compared against
> > > > zero, so this change should not break anything.
> > > >
> > > > Sponsored-by: Sovereign Tech Fund
> > > > Signed-off-by: Niklas Haas <git at haasn.dev>
> > > > ---
> > > >  libswscale/swscale_internal.h | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > this breaks:
> > >
> > > ./ffmpeg -i lena.pnm -vf scale=iw:ih:flags=0x000002:sws_dither=0,format=bgr4_byte -bitexact whatever.bmp
> >
> > This is expected, of course. Are you saying that the change in consistency is
> > not worth the risk of breaking users who directly specify numeric IDs instead
> > of using the symbolic names?
>
> iam not really sure what to do but
> 0 has a feeling of "none" to me

Well, I also wanted to add a "none" option to the enum, so maybe I can make
that be the value of 0. I just think that it's weird for the default value of
an enum option to be something other than 0, and the default should probably
be "auto". (Otherwise, what's the point of the "auto" option?)

>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is what and why we do it that matters, not just one of them.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list