[FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

Michael Niedermayer michael at niedermayer.cc
Tue Oct 8 23:14:14 EEST 2024


On Tue, Oct 08, 2024 at 09:10:05AM +0300, Martin Storsjö wrote:
> On Tue, 8 Oct 2024, Niklas Haas wrote:
> 
> > > Sorry for not checking this earlier, but PowerPC 32- and 64-bit builds
> > > with AltiVec enabled now fail with:
> > > 
> > > src/libswscale/ppc/yuv2yuv_altivec.c: In function ‘ff_get_unscaled_swscale_ppc’:
> > > src/libswscale/ppc/yuv2yuv_altivec.c:199:33: error: assignment to
> > > ‘SwsFunc’ {aka ‘int (*)(SwsContext *, const unsigned char * const*,
> > > const int *, int,  int,  unsigned char * const*, const int *)’} from
> > > incompatible pointer type ‘int (*)(SwsContext *, const uint8_t **, int
> > > *, int,  int,  uint8_t **, int *)’ {aka ‘int (*)(SwsContext *, const
> > > unsigned char **, int *, int,  int,  unsigned char **, int *)’}
> > > [-Wincompatible-pointer-types]
> > >   199 |             c->convert_unscaled = yv12toyuy2_unscaled_altivec;
> > >       |                                 ^
> > > src/libswscale/ppc/yuv2yuv_altivec.c:201:33: error: assignment to
> > > ‘SwsFunc’ {aka ‘int (*)(SwsContext *, const unsigned char * const*,
> > > const int *, int,  int,  unsigned char * const*, const int *)’} from
> > > incompatible pointer type ‘int (*)(SwsContext *, const uint8_t **, int
> > > *, int,  int,  uint8_t **, int *)’ {aka ‘int (*)(SwsContext *, const
> > > unsigned char **, int *, int,  int,  unsigned char **, int *)’}
> > > [-Wincompatible-pointer-types]
> > >   201 |             c->convert_unscaled = yv12touyvy_unscaled_altivec;
> > >       |                                 ^
> > > make: *** [src/ffbuild/common.mak:81: libswscale/ppc/yuv2yuv_altivec.o] Error 1
> > 
> > My bad for missing this one. Is there a public way I can test build on different
> > platforms before submitting series? I would have thought that posting it on the
> > ML is enough to trigger FATE runs on all platforms, but I didn't get any email
> > reply to the series.

I tested it on several platforms but it seems not any that caught this


> 
> No, there's no such infrastructure for running FATE across the various
> (individually driven) instances that voluntarily run tests more or less
> frequently, unfortunately. There is some minimal testing hooked up via
> patchwork though.

This should be expanded. Ideally patchwork should test a broader set

but then again, thats how development works, not everything can be caught
at some point its more work to catch these things than to just fix it in a 2nd
commit.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241008/c2dc11f5/attachment.sig>


More information about the ffmpeg-devel mailing list