[FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field
Anton Khirnov
anton at khirnov.net
Tue Oct 15 11:30:53 EEST 2024
Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26)
> On 2024-10-14 22:35 +0200, Anton Khirnov wrote:
> > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38)
> > > > It is documented in the header.
> > >
> > > I figured as much but couldn't find a hint in in avfilter.h
> > >
> > > You changed it in a previous patch of this series or am I reading it wrong?
> >
> > I don't follow, I changed what?
>
> No, I don't mean you did sth.
>
> I'm just too stupid to read where in avfilter.h it is documented
> to be private.
>
> So I'm asking what is written where that indicates this.
Here:
http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavfilter/avfilter.h;h=b88b31a834094f15d3159b017438499f1809b82f;hb=HEAD#l247
Of course experience shows that such warnings do not really work, as
users ignore or fail to notice them. Which is why we have been switching
to an approach that outright removes private information from public
headers, but that first requires to eliminate its use.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list