[FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

[Michael Niedermayer]

On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel wrote:
> This is as subject notes an RFC. I wanted to send it out quickly.
> Didn't actually test on zlib systems yet (old and new).
> 
> So it is not that heavily tested yet and maybe has rough edges I
> didn't notice.
> 
> I hope this would help to unbreak zlib-ng systems and not disturb
> systems with older zlib versions.
> 
> The strategy is
> 
> 1. re-apply Ramiro's patch to use compression level 0
> 2. fix the 2 tests that fail with older zlib with extra ref file
> 
> The mechanism should only be used when other solutions are not
> available. The alternative files could be dropped in the future
> e.g. when no more fate clients fail because of it.
> 
> 
> Best regards,
>   Alexander
> 
> 
> Alexander Strasser (2):
>   Reapply "tests/fate: disable compression for zlib-based codecs"
>   fate: Make it possible to have alternative reference files
> 
>  tests/fate-run.sh                         | 10 ++++++
>  tests/fate/cover-art.mak                  |  6 ++--
>  tests/fate/image.mak                      |  4 +--
>  tests/fate/lavf-image.mak                 |  5 +--
>  tests/fate/lavf-video.mak                 |  4 +--
>  tests/fate/mov.mak                        |  2 +-
>  tests/fate/vcodec.mak                     |  4 ++-
>  tests/ref/fate/copy-apng                  |  4 +--
>  tests/ref/fate/cover-art-aiff-id3v2-remux |  6 ++--
>  tests/ref/fate/cover-art-flac-remux       |  6 ++--
>  tests/ref/fate/cover-art-mp3-id3v2-remux  |  6 ++--
>  tests/ref/fate/mov-cover-image            |  6 ++--
>  tests/ref/fate/mov-cover-image.alt        | 42 +++++++++++++++++++++++
>  tests/ref/fate/png-icc                    |  6 ++--
>  tests/ref/fate/png-mdcv                   |  4 +--
>  tests/ref/fate/png-mdcv.alt               | 22 ++++++++++++
>  tests/ref/lavf/apng                       |  4 +--
>  tests/ref/lavf/apng.png                   |  4 +--
>  tests/ref/lavf/gray16be.png               |  4 +--
>  tests/ref/lavf/png                        |  4 +--
>  tests/ref/lavf/rgb48be.png                |  4 +--
>  tests/ref/seek/vsynth_lena-flashsv        | 40 ++++++++++-----------
>  tests/ref/vsynth/vsynth1-flashsv          |  4 +--
>  tests/ref/vsynth/vsynth1-mpng             |  4 +--
>  tests/ref/vsynth/vsynth1-zlib             |  4 +--
>  tests/ref/vsynth/vsynth2-flashsv          |  4 +--
>  tests/ref/vsynth/vsynth2-mpng             |  4 +--
>  tests/ref/vsynth/vsynth2-zlib             |  4 +--
>  tests/ref/vsynth/vsynth3-flashsv          |  4 +--
>  tests/ref/vsynth/vsynth3-mpng             |  4 +--
>  tests/ref/vsynth/vsynth3-zlib             |  4 +--
>  tests/ref/vsynth/vsynth_lena-flashsv      |  4 +--
>  tests/ref/vsynth/vsynth_lena-mpng         |  4 +--
>  tests/ref/vsynth/vsynth_lena-zlib         |  4 +--

--- ./tests/ref/fate/mov-cover-image.alt	2024-10-18 20:58:45.047495704 +0200
+++ tests/data/fate/mov-cover-image	2024-10-18 20:59:42.975941144 +0200
@@ -20,7 +20,7 @@
 0,      -1088,      -1088,     1024,        6, 0x027e00e8, F=0x5
 0,        -64,        -64,     1024,        6, 0x027e00e8
 1,          0,          0,        0,    25441, 0xe82503b0
-2,          0,          0,        0,  1084000, 0x70fc8139
+2,          0,          0,        0,  1084000, 0x413c7ee9
 0,        960,        960,     1024,        6, 0x027e00e8
 0,       1984,       1984,     1024,        6, 0x027e00e8
 0,       3008,       3008,     1024,        6, 0x027e00e8
Test mov-cover-image failed. Look at tests/data/fate/mov-cover-image.err for details.
make: *** [tests/Makefile:311: fate-mov-cover-image] Error 1


thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241018/38e5cbe9/attachment.sig>