[FFmpeg-devel] [PATCH 05/15] libavformat/flacdec: Export samples md5 as metadata

[James Almer]

On 10/29/2024 11:47 AM, Tomas Härdin wrote:
> Could maybe use some kind of compile-time assert that
> FLAC_STREAMINFO_SIZE == MD5_BYTE_SIZE + 18. I'm thinking putting in st-
>> codecpar->extradata + st->codecpar->extradata_size - MD5_BYTE_SIZE for
> the offset
> 
> Spotify comments
> ----------------
> Make it possible to verify sample checksum for FLAC files
> 
> Possible other solutions:
>      • Make ffmpeg FLAC demuxer capable of optionally check sample
> checksum. One tricky thing is that we currently have heuristics to not
> trust the checksums based on other metadata (known broken transcoding
> software)

If this is available in extradata, why export it a second time as metadata?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241029/f9f106e8/attachment.sig>