[FFmpeg-devel] [PATCH v2] fftools/ffplay: fix crash when vk renderer is null

Leandro Santiago leandrosansilva at gmail.com
Thu Oct 31 22:50:45 EET 2024


When vulkan rendering is requested by the user and fails, ffplay should
exit graciously instead of crash due to a null pointer deref.

Signed-off-by: Leandro Santiago <leandrosansilva at gmail.com>
---
 fftools/ffplay.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index a596972769..56d0a36ca1 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -2612,6 +2612,11 @@ static int create_hwaccel(AVBufferRef **device_ctx)
     if (type == AV_HWDEVICE_TYPE_NONE)
         return AVERROR(ENOTSUP);
 
+    if (!vk_renderer) {
+        av_log(NULL, AV_LOG_ERROR, "Vulkan renderer is not available\n");
+        return AVERROR(ENOTSUP);
+    }
+
     ret = vk_renderer_get_hw_dev(vk_renderer, &vk_dev);
     if (ret < 0)
         return ret;
-- 
2.46.1



More information about the ffmpeg-devel mailing list