[FFmpeg-devel] [PATCH 2/3] aarch64/vvc: Add put_qpel_vx

[Martin Storsjö]

On Wed, 11 Sep 2024, Zhao Zhili wrote:

> From: Zhao Zhili <zhilizhao at tencent.com>
>
> put_luma_v_8_4x4_c:                                      1.0 ( 1.00x)
> put_luma_v_8_4x4_neon:                                   0.0 ( 0.00x)
> put_luma_v_8_8x8_c:                                      3.5 ( 1.00x)
> put_luma_v_8_8x8_neon:                                   0.5 ( 7.00x)
> put_luma_v_8_16x16_c:                                   13.8 ( 1.00x)
> put_luma_v_8_16x16_neon:                                 1.2 (11.00x)
> put_luma_v_8_32x32_c:                                   54.2 ( 1.00x)
> put_luma_v_8_32x32_neon:                                 5.0 (10.85x)
> put_luma_v_8_64x64_c:                                  217.5 ( 1.00x)
> put_luma_v_8_64x64_neon:                                18.8 (11.60x)
> put_luma_v_8_128x128_c:                                886.2 ( 1.00x)
> put_luma_v_8_128x128_neon:                              74.0 (11.98x)
> ---
> libavcodec/aarch64/h26x/dsp.h       |   8 +++
> libavcodec/aarch64/h26x/qpel_neon.S | 100 ++++++++++++++++++++++++++++
> libavcodec/aarch64/vvc/dsp_init.c   |   7 ++
> 3 files changed, 115 insertions(+)

This doesn't look harmful, and looks like the rest of these functions, so 
I guess it's acceptable. Let it be known that I very much dislike the 
structure of these functions, but you're adding more in the same style of 
the old, so I guess that's ok.

// Martin