[FFmpeg-devel] [PATCH 4/7] avformat/mxfdec: Check timecode for overflow

[Michael Niedermayer]

On Sun, Sep 15, 2024 at 08:28:16PM +0200, Tomas Härdin wrote:
> fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer:
> > Fixes: signed integer overflow: 9223372036840103968 + 538976288
> > cannot be represented in type 'long'
> > Fixes: 70604/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-
> > 4844090340999168
> > 
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/mxfdec.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index ac63c0d5add..8eae9f87afa 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -2391,6 +2391,9 @@ static int
> > mxf_parse_physical_source_package(MXFContext *mxf, MXFTrack *source_t
> >                                                physical_track-
> > >edit_rate,
> >                                                source_track-
> > >edit_rate);
> >  
> > +                if (av_sat_add64(start_position, mxf_tc-
> > >start_frame) != start_position + (uint64_t)mxf_tc->start_frame)
> > +                    continue;
> 
> Should error out instead IMO

ok, will error out instead

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240919/4d6def6e/attachment.sig>