[FFmpeg-devel] [PATCH v6 4/5] libavcodec/dnxucdec: DNxUncompressed decoder

[martin schitter]

All the mentioned issues are fixed in v9.

Thanks for your accurate review!

martin

On 23.09.24 00:24, Marton Balint wrote:
>> +    for(y = 0; y < frame->height; y++){
>> +        for(x = 0; x < frame->width; x++){
> 
> You might want to push variable declarations to the loop initializer 
> expression, like "for (int y = 0; ..."
> 
> This is true for all similar cases.

>> +        av_log(avctx, AV_LOG_ERROR,
>> +        "Insufficient size of AVPacket data (pkg size: %d needed: 
>> %d)\n", avpkt->size, needed);
>> +        return AVERROR_EXIT;
> 
> AVERROR_INVALIDDATA

>> +        av_log(avctx, AV_LOG_ERROR,
>> +        "Image width must be a multiple of 2 for YUV 4:2:2 
>> DNxUncompressed!\n");
>> +        return AVERROR_EXIT;
> 
> AVERROR_INVALIDDATA

>> +            av_log(avctx, AV_LOG_ERROR,
>> +            "Unsupported DNxUncompressed pixel format variant: '%s'\n",
>> +            fourcc_buf);
>> +            return AVERROR(ENOSYS);
> 
> AVERROR_PATCHWELCOME