[FFmpeg-devel] [PATCH 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

[Michael Niedermayer]

On Mon, Feb 03, 2025 at 07:35:45PM -0300, James Almer wrote:
> Considerably reduces the size of HEVCSEI and eliminates data copy between threads.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/hevc/hevcdec.c | 4 ++--
>  libavcodec/hevc/refs.c    | 4 ++--
>  libavcodec/hevc/sei.c     | 6 +++++-
>  libavcodec/hevc/sei.h     | 6 +++++-
>  4 files changed, 14 insertions(+), 6 deletions(-)

this segfaults here, will probably retest tomorrow without other patches
but i removed the ones you pointed to

[vist#0:0/hevc @ 0x12015580] [dec:hevc @ 0x1201b240] View with index 1 requested, but only 1 views available in current video sequence (more views may or may not be available in later sequences).
==307141== Thread 6 dec0:0:hevc:
==307141== Invalid read of size 1
==307141==    at 0x93F313: export_multilayer (in ffmpeg/ffmpeg_g)
==307141==    by 0x94B51F: hevc_receive_frame (in ffmpeg/ffmpeg_g)
==307141==    by 0x8798AA: ff_decode_receive_frame_internal (in ffmpeg/ffmpeg_g)
==307141==    by 0x879F54: decode_receive_frame_internal (in ffmpeg/ffmpeg_g)
==307141==    by 0x87A229: avcodec_send_packet (in ffmpeg/ffmpeg_g)
==307141==    by 0x2FBE13: decoder_thread (in ffmpeg/ffmpeg_g)
==307141==    by 0x31D6AE: task_wrapper (in ffmpeg/ffmpeg_g)
==307141==    by 0x4A06608: start_thread (pthread_create.c:477)
==307141==    by 0x772A352: clone (clone.S:95)
==307141==  Address 0x3 is not stack'd, malloc'd or (recently) free'd



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Any man who breaks a law that conscience tells him is unjust and willingly 
accepts the penalty by staying in jail in order to arouse the conscience of 
the community on the injustice of the law is at that moment expressing the 
very highest respect for law. - Martin Luther King Jr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250206/e90991d6/attachment.sig>