[FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

Zhao Zhili quinkblack at foxmail.com
Thu Feb 6 06:00:42 EET 2025


> On Feb 6, 2025, at 05:20, James Almer <jamrial at gmail.com> wrote:
> 
> On 2/5/2025 12:10 PM, Zhao Zhili wrote:
>> -    skip_bits1(gb); /* direct_depenency_all_layers_flag */
>> -    direct_dep_type = get_bits_long(gb, direct_dep_type_len);
>> -    if (direct_dep_type > HEVC_DEP_TYPE_BOTH) {
>> -        av_log(avctx, AV_LOG_WARNING, "Unsupported direct_dep_type: %d\n",
>> -               direct_dep_type);
>> -        return AVERROR_PATCHWELCOME;
>> +    /* direct_depenency_all_layers_flag */
>> +    if (get_bits1(gb)) {
>> +        direct_dep_type = get_bits_long(gb, direct_dep_type_len);
>> +        if (direct_dep_type > HEVC_DEP_TYPE_BOTH) {
>> +            av_log(avctx, AV_LOG_WARNING, "Unsupported direct_dep_type: %d\n",
>> +                   direct_dep_type);
>> +            return AVERROR_PATCHWELCOME;
>> +        }
>>      }
> 
> direct_dep_type is also coded if direct_depenency_all_layers_flag is false when (if I'm reading the spec right) vps->num_direct_ref_layers[1] is not 0.

Fixed in v4.

https://ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339364.html

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list