[FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3"
Soft Works
softworkz at hotmail.com
Fri Feb 7 04:39:56 EET 2025
> -----Original Message-----
> From: Steven Liu <lingjiujianke at gmail.com>
> Sent: Friday, February 7, 2025 3:24 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Cc: softworkz <softworkz at hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce
> default max reload to 3"
>
> softworkz <ffmpegagent at gmail.com> 于2025年1月19日周日 16:52写道:
> >
> > From: softworkz <softworkz at hotmail.com>
> >
> > This change has caused regressions for many users and consumers.
> > Playlist reloads only happen when a playlist doesn't indicate that
> it
> > has ended (via #EXT-X-ENDLIST), which means that the addition of
> future
> > segments is still expected.
> > It is well possible that an HLS server is temporarily unable to
> serve
> > further segments but resumes after some time, either indicating a
> > discontinuity or even by fully catching up.
> > With a segment length of 3s, a max_reload value of 1000 corresponds
> to
> > a duration of 50 minutes which appears to be a reasonable default.
Hi Steven,
thanks for reviewing
> I have no opinion about this, lgtm
Neither do I. As this is a reversion, I meant to say that the original value wasn't irrational as it might have appeared when the change to 3 was made.
Whether it's 100, 1000 or 10000 might be debatable, just 3 is way too low, so without any strong reason towards 100 or 10000, I think that going back to the original value makes the most sense.
Thanks
sw
More information about the ffmpeg-devel
mailing list