[FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

Marth64 marth64 at proxyid.net
Fri Feb 7 05:58:14 EET 2025


It works good. First pass thoughts:
1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case
convention and conveys clearly that the parameter is an `AVBPrint`

2- Option switch: +datetime and +time feels lighter/easier (vs. -ing)

3- Term color: the space after the time keeps the background of the
time, which looks odd IMO with terminal emulator color schemes that
show the background.
Not sure if this is intentional. Let me know if you need a screenshot.

4- (Optional): how would you feel about RFC3339 representation? If
machine parsing is a goal for this.


More information about the ffmpeg-devel mailing list