[FFmpeg-devel] [PATCH 10/11] avutil/mastering_display_metadata: deprecate av_mastering_display_metadata_alloc()

[James Almer]

It's superfluous ever since av_mastering_display_metadata_alloc_size() was added, and
promotes the use of sizeof(AVMasteringDisplayMetadata) outside of libavutil, which is
not allowed by the ABI.

Signed-off-by: James Almer <jamrial at gmail.com>
---
 libavutil/mastering_display_metadata.c | 2 ++
 libavutil/mastering_display_metadata.h | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
index 48d8b04cc8..814b4a6edb 100644
--- a/libavutil/mastering_display_metadata.c
+++ b/libavutil/mastering_display_metadata.c
@@ -39,10 +39,12 @@ void ff_mdm_get_defaults(void *obj)
     mastering->max_luminance  = (AVRational) { 0, 1 };
 }
 
+#if FF_API_CREATE_SIDE_DATA
 AVMasteringDisplayMetadata *av_mastering_display_metadata_alloc(void)
 {
     return av_mastering_display_metadata_alloc_size(NULL);
 }
+#endif
 
 AVMasteringDisplayMetadata *av_mastering_display_metadata_alloc_size(size_t *size)
 {
diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
index 60ca817eff..0ec36ca88f 100644
--- a/libavutil/mastering_display_metadata.h
+++ b/libavutil/mastering_display_metadata.h
@@ -70,14 +70,18 @@ typedef struct AVMasteringDisplayMetadata {
 
 } AVMasteringDisplayMetadata;
 
+#if FF_API_CREATE_SIDE_DATA
 /**
  * Allocate an AVMasteringDisplayMetadata structure and set its fields to
  * default values. The resulting struct can be freed using av_freep().
  *
+ * @deprecated use @ref av_mastering_display_metadata_alloc_size()
  * @return An AVMasteringDisplayMetadata filled with default values or NULL
  *         on failure.
  */
+attribute_deprecated
 AVMasteringDisplayMetadata *av_mastering_display_metadata_alloc(void);
+#endif
 
 /**
  * Allocate an AVMasteringDisplayMetadata structure and set its fields to
-- 
2.48.1