[FFmpeg-devel] [PATCH v6 7/9] tests: Add chained ogg/flac stream dump test.

[Romain Beauxis]

Le ven. 21 févr. 2025 à 05:01, Michael Niedermayer
<michael at niedermayer.cc> a écrit :
>
> On Tue, Feb 18, 2025 at 11:24:43PM -0600, Romain Beauxis wrote:
> > Before:
> > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> >
> > After:
> > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> >
> > ---
> >  tests/Makefile          |  1 +
> >  tests/fate/ogg-flac.mak | 11 +++++++++++
> >  2 files changed, 12 insertions(+)
> >  create mode 100644 tests/fate/ogg-flac.mak
>
> this fails fate:
>
> TEST    ogg-flac-chained-meta
> --- fate-suite//ogg-flac/chained-meta.txt       2025-02-06 03:37:55.000000000 +0100
> +++ tests/data/fate/ogg-flac-chained-meta       2025-02-21 11:58:41.572340528 +0100
> @@ -1,11 +1,11 @@
>  Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
>  Stream ID: 0, frame PTS: 0, metadata:
> -Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> +Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
>  Stream ID: 0, frame PTS: 4608, metadata:
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
>  Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> -Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> +Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
>  Stream ID: 0, frame PTS: 4608, metadata:
> Test ogg-flac-chained-meta failed. Look at tests/data/fate/ogg-flac-chained-meta.err for details.
> make: *** [tests/Makefile:314: fate-ogg-flac-chained-meta] Error 1

Thanks for checking it and sorry I hadn't updated my remote files.

They are all up-to-date now.

I have also updated the PR here with a description of the most recent
changes and the fixed rebase commit:
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/6

Thanks,
-- Romain