[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add options for filtergraph printing

[Nicolas George]

Soft Works (HE12025-02-21):
> Yes, this is all true, but of course I did a diff to current ffprobe code and
> the number of bugfixes is exactly zero.

I did a diff to see if what I suspected was duplicated code was indeed,
and I found it was, and I found failures of synchronization too.

> Strictly speaking, it's not a duplication because one part lives only 
> In ffprobe and the other only in ffmpeg.

That is irrelevant, you copy-pasted code, that is code duplication.

> When I had submitted this patchset in 2021, you had said the same
> thing,

Well, unless I was not paying attention, the same flaws lead to the same
comments.

>	 that you want to work on it, but now it's 4 years later and
> it hasn't happened.

Indeed. “It hasn't happened” is kind of what you should expect when a
prerequisite is being blocked.

> But this can't be a blocker.

You cannot be blocked until the code I had baking is included, but your
code duplication is still a big no, and a big no is blocking.

Regards,

-- 
  Nicolas George