[FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

[Nil Fons Miret]

Thanks for the clarification, attaching an updated patch. The only
change is the one comment on qrencode.c.

Thank you,
Nil

On Fri, Mar 7, 2025 at 7:28 PM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Tue, Mar 04, 2025 at 10:17:25AM -0800, Nil Fons Miret via ffmpeg-devel wrote:
> > I'm not sure I understand what documentation you'd like to add. The
> > behavior of ff_draw_init* is documented in drawutils.h, would you like
> > me to add a comment where these functions are called with no risk of
> > failing (as far as I can see, only qrencode.c)? My worry is that such
> > a comment can easily become outdated. In any case, once I understand
> > your request I'm happy to add any more documentation.
>
> yes, if you add a check that is unreachable and that is intentional
> it should receive a comment.
> Otherwise it can confuse the reader, also it can be removed when someone
> realizes it is unreachable
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Nations do behave wisely once they have exhausted all other alternatives.
> -- Abba Eban
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
-------------- next part --------------
An embedded message was scrubbed...
From: Nil Fons Miret <nilf at netflix.com>
Subject: [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures
Date: Fri, 21 Feb 2025 01:18:21 +0000
Size: 15964
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250310/fa8f3a85/attachment.eml>