[FFmpeg-devel] [PATCH 09/12] avcodec/sanm: codec4/5/33/34 decoder

[Manuel Lauss]

Servus Andreas,

On Fri, Mar 14, 2025 at 1:08 AM Andreas Rheinhardt
<andreas.rheinhardt at outlook.com> wrote:

> > +static int old_codec4(SANMVideoContext *ctx, int left, int top, int w, int h,
> > +                      uint8_t param, uint16_t param2, int codec)
> > +{
> > +    const uint16_t p = ctx->pitch;
> > +    const uint32_t maxpxo = ctx->height * p;
> > +    uint8_t mask, bits, idx, *gs, *dst = (uint8_t *)ctx->frm0;
> > +    int i, j, k, l, bit, ret;
> > +    int32_t pxoff, pxo2;
> > +

> > +    for (j = 0; j < w; j += 4) {
>
> Why don't you use loop-scope for iterators?

Personal preference, really.    I'll change it if you want me to.

Manuel