[FFmpeg-devel] [PATCH] avcodec/exrdec: restore applying color transfer characteristics for float16 samples

Michael Niedermayer michael at niedermayer.cc
Sun Mar 16 01:42:01 EET 2025


Hi

On Sat, Mar 15, 2025 at 08:36:33PM -0300, James Almer wrote:
> On 3/15/2025 8:35 PM, Michael Niedermayer wrote:
> > Hi
> > 
> > On Thu, Mar 13, 2025 at 11:08:09PM -0300, James Almer wrote:
> > > Regression since 0e917389fe73c932049635d947bba076f1709589.
> > > This change also reverts commit 431805c096738da7661a0baee2b12fe9724dcc95.
> > > 
> > > Signed-off-by: James Almer <jamrial at gmail.com>
> > > ---
> > >   libavcodec/exr.c | 38 ++++++++++++++++++++++++++++++++++++--
> > >   1 file changed, 36 insertions(+), 2 deletions(-)
> > 
> > We dont do that for any other codec.
> > For every other case we export all the color and gamma information
> > but do not modify the sample values to some "normalized" representation
> > 
> > Its also lossy to do it in the decoder like this
> > 
> > thx
> We're still doing it for the float path, so in that case you may want to
> remove it from there too.

I think we should remove it, but I think I have no samples for that code path.
So i would not be able to test ...

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250316/24a36c07/attachment.sig>


More information about the ffmpeg-devel mailing list