[FFmpeg-devel] [PATCH v7 8/8] tests: Add chained ogg/opus stream dump test.

[Michael Niedermayer]

On Mon, Mar 17, 2025 at 01:11:51AM +0100, Michael Niedermayer wrote:
> On Tue, Feb 25, 2025 at 04:01:21PM -0600, Romain Beauxis wrote:
> > ---
> >  tests/Makefile          |  1 +
> >  tests/fate/ogg-opus.mak | 11 +++++++++++
> >  2 files changed, 12 insertions(+)
> >  create mode 100644 tests/fate/ogg-opus.mak
> > 
> > diff --git a/tests/Makefile b/tests/Makefile
> > index a37f2ab587..75b9bcc729 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -221,6 +221,7 @@ include $(SRC_PATH)/tests/fate/mpegts.mak
> >  include $(SRC_PATH)/tests/fate/mxf.mak
> >  include $(SRC_PATH)/tests/fate/ogg-vorbis.mak
> >  include $(SRC_PATH)/tests/fate/ogg-flac.mak
> > +include $(SRC_PATH)/tests/fate/ogg-opus.mak
> >  include $(SRC_PATH)/tests/fate/oma.mak
> >  include $(SRC_PATH)/tests/fate/opus.mak
> >  include $(SRC_PATH)/tests/fate/pcm.mak
> > diff --git a/tests/fate/ogg-opus.mak b/tests/fate/ogg-opus.mak
> > new file mode 100644
> > index 0000000000..75cb15bc05
> > --- /dev/null
> > +++ b/tests/fate/ogg-opus.mak
> > @@ -0,0 +1,11 @@
> > +FATE_OGG_OPUS += fate-ogg-opus-chained-meta
> > +fate-ogg-opus-chained-meta: REF = $(SAMPLES)/ogg-opus/chained-meta.txt
> > +fate-ogg-opus-chained-meta: CMD = $(APITESTSDIR)/api-dump-stream-meta-test$(EXESUF) $(TARGET_SAMPLES)/ogg-opus/chained-meta.ogg
> > +
> > +FATE_OGG_OPUS-$(call DEMDEC, OGG, OPUS) += $(FATE_OGG_OPUS)
> > +
> > +FATE_SAMPLES_DUMP_STREAM_META += $(FATE_OGG_OPUS-yes)
> > +
> > +FATE_EXTERN += $(FATE_OGG_OPUS-yes)
> > +
> > +fate-ogg-opus: $(FATE_OGG_OPUS-yes)
> 
> fails on mingw64
> 
> --- src/tests/ref/fate/ogg-opus-chained-meta.txt	2025-03-16 23:56:34.170930298 +0100
> +++ tests/data/fate/ogg-opus-chained-meta	2025-03-17 01:08:35.230686947 +0100
> @@ -1,27 +0,0 @@
> -Stream ID: 0, codec name: opus, metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> -Stream ID: 0, frame PTS: -312, metadata:
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> -Stream ID: 0, frame PTS: -312, metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> Test ogg-opus-chained-meta failed. Look at tests/data/fate/ogg-opus-chained-meta.err for details.
> src/tests/fate-run.sh: 1: eval: tests/api/api-dump-stream-meta-test.exe: Exec format error
> threads=1
> make: *** [src/tests/Makefile:315: fate-ogg-opus-chained-meta] Error 2
> 
> wine tests/api/api-dump-stream-meta-test.exe
> vs.
> tests/api/api-dump-stream-meta-test.exe

similar issue on mips (qemu instead of wine)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
than the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250317/a0ee6be8/attachment.sig>