[FFmpeg-trac] #10431(avfilter:new): Bug in lut3d.c
FFmpeg
trac at avcodec.org
Fri Jun 23 11:10:18 EEST 2023
#10431: Bug in lut3d.c
--------------------------------------+------------------------------------
Reporter: Michael Koch | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: avfilter
Version: git-master | Resolution:
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
--------------------------------------+------------------------------------
Comment (by Michael Koch):
Replying to [comment:7 Elon Musk]:
> Please cite specification to make this valid link. Not going to research
whole specification from link for you, have not much that free time.
It seems there exist two different syntax specifications:
1.
LUT_1D_INPUT_RANGE min max
LUT_3D_INPUT_RANGE min max
The first one is already implemented in lut3d.c, but clipped to wrong
range in lines 1763 to 1765. For examples see
https://forum.blackmagicdesign.com/viewtopic.php?f=21&t=40284
2.
DOMAIN_MIN rl gl bl
DOMAIN_MAX rh gh bh
For specification see chapter 5.6 in
https://web.archive.org/web/20201027210201/https://wwwimages2.adobe.com/content/dam/acom/en/products/speedgrade/cc/pdfs
/cube-lut-specification-1.0.pdf
See also this implementation, beginning in line 142:
https://github.com/JakubOchnik/Cube-LUT-
Loader/blob/main/src/DataLoader/CubeLUT.cpp
I'm not sure which of these two syntax versions is newer or older.
Seems best if FFmpeg accepts both of them for compatibility.
--
Ticket URL: <https://trac.ffmpeg.org/ticket/10431#comment:8>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list