[FFmpeg-trac] #2266(avcodec:closed): support flac crcchecks

FFmpeg trac at avcodec.org
Tue Sep 26 12:01:16 EEST 2023


#2266: support flac crcchecks
-------------------------------------+-----------------------------------
             Reporter:  dave rice    |                    Owner:  (none)
                 Type:  enhancement  |                   Status:  closed
             Priority:  wish         |                Component:  avcodec
              Version:  git-master   |               Resolution:  fixed
             Keywords:  flac crc     |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-----------------------------------
Comment (by Balling):

 >Before you would get sometimes invalid data from fully valid .flac files.

 #9621 was valid file that flac.exe accepts no problem, but you broke this
 issue, I even mentioned


 >I think we are not going to validate crc16 by default

 So not by default we still will. Just like this "verified with the
 AV_EF_CRCCHECK flag":
 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230809174657.76-1-tcChlisop0@gmail.com/


 By the way, I have a question. ​https://files.catbox.moe/kvvrac.flac is a
 file from torrents (you can find it with Btdigg). Can you tell me why is
 it corrupted? Is it possible to bruteforce and restore it?


 Also, I do not get it why cannot I reopen old issues. It is common to do
 that when issue regresses in other projects.
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/2266#comment:11>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list