[FFmpeg-trac] #11451(avformat:new): Ogg/Theora: Duplicate frames dropped when copying Theora streams

[FFmpeg]

#11451: Ogg/Theora: Duplicate frames dropped when copying Theora streams
------------------------------------+------------------------------------
             Reporter:  Bernat      |                    Owner:  (none)
                 Type:  defect      |                   Status:  new
             Priority:  normal      |                Component:  avformat
              Version:  git-master  |               Resolution:
             Keywords:              |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+------------------------------------
Comment (by James):

 Does this fix the issue?

 {{{
 diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c
 index 224519a4da..57bf5b3509 100644
 --- a/libavformat/oggenc.c
 +++ b/libavformat/oggenc.c
 @@ -241,7 +241,8 @@ static int ogg_buffer_data(AVFormatContext *s,
 AVStream *st,

          len = FFMIN(size, segments*255);
          page->segments[page->segments_count++] = len - (segments-1)*255;
 -        memcpy(page->data+page->size, p, len);
 +        if (len)
 +            memcpy(page->data+page->size, p, len);
          p += len;
          size -= len;
          i += segments;
 @@ -690,7 +691,7 @@ static int ogg_write_packet(AVFormatContext *s,
 AVPacket *pkt)
      int i;

      if (pkt)
 -        return pkt->size ? ogg_write_packet_internal(s, pkt) : 0;
 +        return pkt->size || !pkt->side_data_elems ?
 ogg_write_packet_internal(s, pkt) : 0;

      for (i = 0; i < s->nb_streams; i++) {
          OGGStreamContext *oggstream = s->streams[i]->priv_data;
 }}}
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/11451#comment:5>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker