[FFmpeg-trac] #11591(avcodec:closed): [Regression] Closed Captions extraction garbled (was: closed captions side data gets corrupted by mpeg2 encoder)

[FFmpeg]

#11591: [Regression] Closed Captions extraction garbled
---------------------------------------+-----------------------------------
             Reporter:  Jacob Lifshay  |                    Owner:  (none)
                 Type:  defect         |                   Status:  closed
             Priority:  normal         |                Component:  avcodec
              Version:  git-master     |               Resolution:  fixed
             Keywords:  mpeg12enc      |               Blocked By:
             Blocking:                 |  Reproduced by developer:  0
Analyzed by developer:  1              |
---------------------------------------+-----------------------------------
Changes (by MasterQuestionable):

 * analyzed:  0 => 1
 * cc: MasterQuestionable (added)
 * keywords:  regression, mpeg2video => mpeg12enc
 * summary:  closed captions side data gets corrupted by mpeg2 encoder =>
     [Regression] Closed Captions extraction garbled

Comment:

 ͏    @ 2025-05-16T10:20:18Z
 ͏    avcodec/mpeg12enc: Fix writing closed captions
 https://github.com/FFmpeg/FFmpeg/commit/45daaf2caaa3dc8bf8c505a9fc61a61b989721dc
 ͏    “"ff_copy_bits" expects the amount of bits, not bytes to write.
 ͏    And because it relies on the buffer to be padded: using
 !`side_data->size * 8` is not possible.
 ͏    So partially revert said commit.”

 ͏    ----

 ͏    @ 2025-03-07T14:19:03Z
 ͏    avcodec/mpeg12enc: Simplify writing bits
 ͏
 https://github.com/FFmpeg/FFmpeg/commit/6e225123d8583fdce55037b85eaef5453f201959
 ͏    .
 ͏    Looks like unintended change caused.

 ͏    For reference:
 ͏    https://trac.ffmpeg.org/ticket/11263#comment:12
 ͏    (probably not much related)
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/11591#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker