[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec ac3enc.c,1.29,1.30
Sat Apr 8 02:14:54 CEST 2006
Justin Ruggles wrote:
> Corey Hickey wrote:
>> I would expect that the change is intended and the regresssion results
>> should be altered correspondingly. Justin, please comment. I'll patch
>> the results tomorrow if I don't hear otherwise.
> Yes, that would be the expected result for any 44100/22050/11025 Hz
> files. I see you have updated regression results already...great!
> For future reference, if I submit a patch for approval which would
> knowingly break regression tests, should I include an update in the
> patch or should I just mention it and leave it to the admins if/when the
> patch is accepted?
Yes, please include it in the patch. Anyone who sees your patch will see
the regression differences are intentional and anyone who tests it can
compare their tests with yours.
> It didn't even cross my mind to check this time...sorry.
No problem. Neither you nor Michael nor I even thought about it. :)
More information about the ffmpeg-cvslog