[Ffmpeg-cvslog] r8204 - trunk/libavformat/mov.c

The Wanderer inverseparadox
Sat Mar 3 22:00:08 CET 2007

Michael Niedermayer wrote:

> Hi
> On Sat, Mar 03, 2007 at 08:48:35PM +0100, Baptiste Coudurier wrote:

>> You going to revert it for 2 lines of fourccs even more when those
>> 2 lines are mentioned in the commit log ?
> yes


> btw, i didnt even realize that its 2 lines and that exactly is the
> problem with such commits you never know what really has been changed
> if cosmetics get mixed with functional changes

I read through the patch looking for the change described, to make sure
I wasn't incorrect before posting, and I was unable to even tell with
certainty (in a reasonable amount of time) which lines contained the new
tags - because the table was also being rearranged by the same commit.
As a result, I was unable to be sure whether or not a non-cosmetic
change had been made.

This is part of the reason for the rule against mixing functional and
cosmetic changes, and part the reason for the rule against mixing
unrelated changes: it makes reading the patch to find a particular
change harder. (It also means that if one change ever needs to be
reverted, it is significantly harder to do so without also reverting any
others which were in the same patch.)

       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.

More information about the ffmpeg-cvslog mailing list