[FFmpeg-cvslog] r8960 - trunk/libavcodec/pcm.c
Ramiro Ribeiro Polla
Thu May 10 02:18:17 CEST 2007
Michael Niedermayer wrote:
> On Thu, May 10, 2007 at 01:08:01AM +0200, ramiro wrote:
>> Author: ramiro
>> Date: Thu May 10 01:08:01 2007
>> New Revision: 8960
>> Factorize usum
> are you pcm.c maintainer? no?
> did you send a patch? no?
> is this change doing anything good besides bloating the code?
> did you benchmark the code?
> if the change would make sense i wouldnt mind if you commited without
> sending a patch but it doesnt, at least its not obvious what good it does
> these functions are static inline and the compiler will if it inlines
> them optimize the check away, and the functions are small so i guess
> gcc will inline them
Sorry, I forgot to ask. Should I revert it?
More information about the ffmpeg-cvslog