[FFmpeg-cvslog] r8960 - trunk/libavcodec/pcm.c
Thu May 10 02:22:10 CEST 2007
On Wed, May 09, 2007 at 09:18:17PM -0300, Ramiro Ribeiro Polla wrote:
> Michael Niedermayer wrote:
> > Hi
> > On Thu, May 10, 2007 at 01:08:01AM +0200, ramiro wrote:
> >> Author: ramiro
> >> Date: Thu May 10 01:08:01 2007
> >> New Revision: 8960
> >> Log:
> >> Factorize usum
> > are you pcm.c maintainer? no?
> > did you send a patch? no?
> > is this change doing anything good besides bloating the code?
> > did you benchmark the code?
> > if the change would make sense i wouldnt mind if you commited without
> > sending a patch but it doesnt, at least its not obvious what good it does
> > these functions are static inline and the compiler will if it inlines
> > them optimize the check away, and the functions are small so i guess
> > gcc will inline them
> Sorry, I forgot to ask. Should I revert it?
if it has no advantage (not faster, not smaller object) then yes but this
isnt overly important also iam the one responsibly and the one who should test
it and revert as i oked the patch without realizing that half of the what
it changed wasnt actually doing much good ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-cvslog