[FFmpeg-cvslog] r15002 - in trunk/libavformat: internal.h sdp.c utils.c
Ronald S. Bultje
Thu Aug 28 04:10:06 CEST 2008
On Wed, Aug 27, 2008 at 9:01 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>> Aurelien Jacobs <aurel at gnuage.org> writes:
>> > Sorry that I didn't catch this when you submitted the patch, but
>> > here, the multiple inclusion guard should be FFMPEG_INTERNAL_H.
>> > But now that I think about it. This would cause clashes with
>> > the multiple inclusion guard from lavu/interal.h.
>> > I guess that was one of the reason why I preferred AVFORMAT_FILE_H
>> > as a standard inclusion guard instead of FFMPEG_FILE_H at the time
>> > this was decided.
>> > Should we consider a new rename of all inclusion guards ?
> So would you agree renaming all of them to AVFORMAT_*, AVCODEC_*, etc ?
> Would anyone be against it ?
Nice catch. We'll have multiple of those cases in the future, I'm
affraid, your solution sounds great!
More information about the ffmpeg-cvslog