[FFmpeg-cvslog] r15002 - in trunk/libavformat: internal.h sdp.c utils.c
Fri Aug 29 00:28:06 CEST 2008
On Thu, Aug 28, 2008 at 03:01:26AM +0200, Aurelien Jacobs wrote:
> M?ns Rullg?rd wrote:
> > Aurelien Jacobs <aurel at gnuage.org> writes:
> > > rbultje wrote:
> > >
> > >> --- (empty file)
> > >> +++ trunk/libavformat/internal.h Thu Aug 28 01:43:28 2008
> > >> @@ -0,0 +1,26 @@
> > >> +
> > >> +#ifndef FFMPEG_AVFORMAT_UTILS_H
> > >> +#define FFMPEG_AVFORMAT_UTILS_H
> > >
> > > Sorry that I didn't catch this when you submitted the patch, but
> > > here, the multiple inclusion guard should be FFMPEG_INTERNAL_H.
> > > But now that I think about it. This would cause clashes with
> > > the multiple inclusion guard from lavu/interal.h.
> > > I guess that was one of the reason why I preferred AVFORMAT_FILE_H
> > > as a standard inclusion guard instead of FFMPEG_FILE_H at the time
> > > this was decided.
> > > Should we consider a new rename of all inclusion guards ?
> > It was Diego who renamed them all to FFMPEG_*. I never understood his
> > reasoning behind it.
> So would you agree renaming all of them to AVFORMAT_*, AVCODEC_*, etc ?
> Would anyone be against it ?
I think we/I chose FFMPEG_ for simplicity back then. I agree that
AVCODEC_ etc. is the better solution in the long run.
More information about the ffmpeg-cvslog