[FFmpeg-cvslog] r31772 - trunk/libswscale/swscale.h

Michael Niedermayer michaelni
Tue Jul 27 03:28:39 CEST 2010

On Sun, Jul 25, 2010 at 11:58:33AM +0200, Stefano Sabatini wrote:
> On date Saturday 2010-07-24 14:45:51 +0200, Michael Niedermayer wrote:
> > On Fri, Jul 23, 2010 at 01:01:31AM +0200, stefano wrote:
> > > Author: stefano
> > > Date: Fri Jul 23 01:01:31 2010
> > > New Revision: 31772
> > > 
> > > Log:
> > > Prefer impersonal form over third person, for consistency with the
> > > rest of FFmpeg.
> > 
> > you are not a native english person, so at the least this
> > should have been submitted as patch and checked by someone who is a
> > native english speaker
> That's why I find silly the native englis person review rule. What we
> need is a set of written conventions to follow, there is no sense into
> demanding a "native English person" to review the patch if the rule to
> follow are clear enough (and we don't have so much review man-power,
> so the less we demand the better it is).

a written convention, so someone who is bad at english can change grammer of
english text?
do you also want a written convention so you can change tibetan from 3rd
person to impersonal form?

and about review man power, this change is completely unneeded bikeshed
its not "ohh my god we need this critical fix in there lets skip review"
above all the comments must be correct their style is secondary if not
further down the list.
its rather that previously it was 3rd person is preferred now natives
prefer 1st next year its second then we change all doxy to swedish 

also theres the thing that controversal changes should be discussed first
and one should not knowingly step on other developers toes when commiting.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100727/81c04c07/attachment.pgp>

More information about the ffmpeg-cvslog mailing list