[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

Tobias Bindhammer tobias.bindhammer
Fri Oct 8 20:02:34 CEST 2010


> There is no such rule
>
> Yes maybe 5 people somewhere on IRC agreed to something, i dont know but that
> makes about as much a binding rule for everyone as 5 workers in the bar
> agreeing to something is binding for the other 500 of their coleges and their
> boss is.
>
> I hope you see what iam trying to say and dont missunderstand me, ive no
> intent to flame iam just trying to point out that rules are written in the
> policy and that they need to be publically and carefully discussed and agreed
> to by people. What doesnt make it into the policy is not something  that was
> sufficiently discussed and agreed upon.
>
> And as we are at the subject before we all go into a rewrite the policy
> crussade, please everyone cool down, messing with policy and rules requires
> a clear mind and carefull thoughts as stringing us down in more rules will
> do more harm than good. (id like a variables need to be understandable without
> knowing the spec rule but i also know this will do harm by angering some
> developers)
>
> [...]

Well, i am following this discussion now for a while, and have to admit 
that quite some unwritten/inspired/name it rules kind of annoyed me in 
the beginning. As for the coding style i also had to strongly adopt my 
habits, but it turned out to be an big advantage for me and those who 
read my code now on other projects i do. Getting (mostly) used to the 
suggested indent-style here was not too much of an effort, and as 
already suggested by Reimar, some syntax-highlighting that let your eyes 
bleed helped for the beginning, as well as accepting, that my previous 
style simply sucked, and was okay for own prjects, but not when working 
together with others. However we could still discuss things more 
relaxed, forget a space here and there somewhen, and just do a commit 
with cosmetic changes when we feel bored and not like coding.

Toby



More information about the ffmpeg-cvslog mailing list