[Ffmpeg-devel] [PATCH] Vorbis decoder

Michael Niedermayer michaelni
Fri May 13 18:27:19 CEST 2005


On Friday 13 May 2005 17:28, Balatoni Denes wrote:
> > > +    uint32_t ret=0;
> >
> > exact width types should only be used when an exact width is needed (not
> > for local variables like ret,i, ...)
> I tried to use the possible minimal size for each variable. So if for
> example somebody wants to port this decoder to C64 or ZX Spectrum, he will
> know where he can use native 8 bit types, or needs 16 bits, or must use
> more than 16 bits (in those cases 32 bits are usually not needed though).

(u)intXY_t means exact length twos complement style, and as you are trying to 
justify their use with obscure hw, well thats exactly where its a very bad 

(u)int_fastXY_t is what you should use if you dislike int/short/long


More information about the ffmpeg-devel mailing list