[Ffmpeg-devel] [PATCH] Vorbis I floor type 0 support

Alexander Strasser eclipse7
Sun Jan 29 03:52:19 CET 2006


Alex Beregszaszi wrote:
> >   i extended the ffmpeg vorbis decoder to decode
> > vorbis floor0 files. It is my first try at this
> > kind of stuff. I only had one sample tho testing
> > wasn't too exhaustive. I tested the code on linux
> > x86 and Solaris SPARC so far.
> > 
> >   As always comments and testers welcome.
> One comment: what about the indentation of the union for type1 in the
> header file?

  Being used to the strict anti-cosmetic rules from MPlayer
project i intentionally left it that way, so reviewers could
see i did not change anything in the type1 data. I think the
don't indent more then 5 lines rule is in ffmpeg doc now too.
  But i will correct it with another cosmetic-only commit.

> Anyway, I would say to commit.

  Especially as it doesn't affect the type1 parts (if i didn't
mess up, that is), i would like to get it in now too. I think
the risk of breaking anything even before the release is low.

  Objections anyone?

  Alex (beastd)

More information about the ffmpeg-devel mailing list