[Ffmpeg-devel] [PATCH] non conformance to 3GP format (3GP TS 26.244 v 6.5.0 2006/06) 2nd try

ffmpeg ffmpeg
Fri Jul 28 15:13:52 CEST 2006


I would like to submit for review (and maybe integration) the following 
This is my 2nd try, now based on 5829 (trying to follow last version)

Purpose:  Fix some non conformance to 3GP format  (3GP TS 26.244 v 6.5.0 
Applies:   libavcodec/movenc.c {SVN 5720}, (test within trunk SVN 5829)
Testing:        - Regression test OK;
     - 3GP file check with some commercial 3gp analysis tools
     - play on QuickTime
     - play on HP OCMP Video 1.0
Authors:   Francois Draperi
   Some fields (like in 'samr' atom) are not set to 0; "3GP TS 26.244" 
enforces those values to be null.     
   The patch simply put 0 in the needed audio and video atom fields, for
   3GP files (and only them), and for AMR_NB mode (and only this codec).
   Maybe someone may also ask to restrict those changes to the '-strict 
very' mode, but is it useful ?
    As suggested by Baptiste C., should also applies to mp4v, mp4a, and 
potentially avc1. I do not know enough those, so I let someone else do 
the change.

Hope that help
Francois Draperi.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.ffmpeg.movenc.c.5720b
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060728/fc9d3a7d/attachment.asc>

More information about the ffmpeg-devel mailing list