[Ffmpeg-devel] [PATCH] non conformance to 3GP format (3GP TS 26.244 v 6.5.0 2006/06) 2nd try

Michael Niedermayer michaelni
Fri Jul 28 21:18:46 CEST 2006


On Fri, Jul 28, 2006 at 03:13:52PM +0200, ffmpeg wrote:
> Hello,
> I would like to submit for review (and maybe integration) the following 
> patch,
> This is my 2nd try, now based on 5829 (trying to follow last version)
> Purpose:  Fix some non conformance to 3GP format  (3GP TS 26.244 v 6.5.0 
> 2006/06)
> Applies:   libavcodec/movenc.c {SVN 5720}, (test within trunk SVN 5829)
> Testing:        - Regression test OK;
>     - 3GP file check with some commercial 3gp analysis tools
>     - play on QuickTime
>     - play on HP OCMP Video 1.0
> Authors:   Francois Draperi
> Discussion:
>   Some fields (like in 'samr' atom) are not set to 0; "3GP TS 26.244" 
> enforces those values to be null.     
>   The patch simply put 0 in the needed audio and video atom fields, for
>   3GP files (and only them), and for AMR_NB mode (and only this codec).
>   Maybe someone may also ask to restrict those changes to the '-strict 
> very' mode, but is it useful ?
> ToDo:
>    As suggested by Baptiste C., should also applies to mp4v, mp4a, and 
> potentially avc1. I do not know enough those, so I let someone else do 
> the change.

patch looks ok, assuming regression tests pass, and whoever applies it 
should also fix the indention in a second, seperate commit

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list