[Ffmpeg-devel] Re: Another question about cropping and scaling
Fri Mar 10 13:34:17 CET 2006
On Fri, Mar 10, 2006 at 09:04:44AM +0100, Luca Abeni wrote:
> Hi Baptiste,
> first of all, thanks for you feedback.
> On Thu, 2006-03-09 at 17:29 +0100, Baptiste COUDURIER wrote:
> > > + picture_pad_temp.data = final_picture->data +
> > > + ((ost->padtop >> 1) * final_picture->linesize) +
> > > + (ost->padleft >> 1);
> > > +
> > Yes, those >>1 are wrong. It depends on x and y chroma shifts, depending
> > on enc pix_fmt.
> Well, I did not change it because I saw your crop patch, and I think
> that img_crop() can be used here too.
> Anyway, you are right: I'll rebase my work on your patch.
> BTW, Michael, what's the status of Baptiste's crop patch? Can it be
> committed? (I am asking because I am working on similar stuff, and
> assuming that Baptiste's patch will go in would simplify my own patch :)
More information about the ffmpeg-devel