[Ffmpeg-devel] [PATCH] change gif demuxer to gif decoder

[Michael Niedermayer]

Hi

On Sun, Oct 22, 2006 at 03:21:23PM +0200, Baptiste Coudurier wrote:
> Hi
> 
> Michael Niedermayer wrote:
> >> [...]
> >>
> >> Those get_* might be located in another file though.
> > 
> > yes
> > 
> 
> bitstream.h ? new bytestream.h ? Those functions need to be renamed
> since it will conflict with libavformat. get_le*_buf ?

new bytestream.h seems cleaner, bitstream.h is already a huge mess


[...]
> > [...]
> >> +    picture->data[0] = s->image_buf;
> >> +    picture->linesize[0] = s->image_linesize;
> >> +    picture->data[1] = s->image_palette;
> >> +    picture->linesize[1] = 4;
> > 
> > AVCodecContext.get_buffer() should be used to allocate the image so that
> > the user app can control where the image is stored avoids memcpy in many
> > cases, but that can be changed in a seperate commit
> > 
> 
> Ok, I'll do that. May I commit ?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is