[Ffmpeg-devel] [PATCH] change gif demuxer to gif decoder

Baptiste Coudurier baptiste.coudurier
Sun Oct 22 17:05:34 CEST 2006


Michael Niedermayer wrote:
> Hi
> 
> On Sun, Oct 22, 2006 at 03:21:23PM +0200, Baptiste Coudurier wrote:
>> Hi
>>
>> Michael Niedermayer wrote:
>>>> [...]
>>>>
>>>> Those get_* might be located in another file though.
>>> yes
>>>
>> bitstream.h ? new bytestream.h ? Those functions need to be renamed
>> since it will conflict with libavformat. get_le*_buf ?
> 
> new bytestream.h seems cleaner, bitstream.h is already a huge mess
> 

Done.

> [...]
>>> [...]
>>>> +    picture->data[0] = s->image_buf;
>>>> +    picture->linesize[0] = s->image_linesize;
>>>> +    picture->data[1] = s->image_palette;
>>>> +    picture->linesize[1] = 4;
>>> AVCodecContext.get_buffer() should be used to allocate the image so that
>>> the user app can control where the image is stored avoids memcpy in many
>>> cases, but that can be changed in a seperate commit
>>>
>> Ok, I'll do that. May I commit ?
> 
> yes
> 
> [...]

Applied.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list