[Ffmpeg-devel] [PATCH] Base64 code

[Ryan Martell]

On Oct 28, 2006, at 1:51 AM, Oded Shimon wrote:

> On Fri, Oct 27, 2006 at 08:07:47PM -0500, Ryan Martell wrote:
>>
>> On Oct 27, 2006, at 7:59 PM, Michael Niedermayer wrote:
>>> [...]
>>>> @@ -203,7 +203,7 @@
>>>>              hoststr,
>>>>              auth_b64);
>>>>
>>>> -    av_freep(&auth_b64);
>>>> +    av_free(auth_b64);
>>>
>>> why?
>>
>> I don't know.  ;-)
>>
>> I allocate it with av_malloc, and have never seen av_freep(), so
>> figured I would change it to something I knew would work right.
>>
>> I assume that av_freep() frees the memory that the pointer points to,
>> but assumptions can get me in trouble...
>
> void av_freep(void**p) { av_free(*p); *p = NULL; }

I guess part of my thought process was why was it done this way.

But mine is not to wonder why, mine is just to patch or die.... ;-)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: http_patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061028/f228c27c/attachment.txt>
-------------- next part --------------

Undid the av_free() and went back to av_freep()

-Ryan