[Ffmpeg-devel] [PATCH] Base64 code

[Michael Niedermayer]

Hi

On Sat, Oct 28, 2006 at 08:45:43PM -0500, Ryan Martell wrote:
> 
> On Oct 28, 2006, at 1:51 AM, Oded Shimon wrote:
> 
> >On Fri, Oct 27, 2006 at 08:07:47PM -0500, Ryan Martell wrote:
> >>
> >>On Oct 27, 2006, at 7:59 PM, Michael Niedermayer wrote:
> >>>[...]
> >>>>@@ -203,7 +203,7 @@
> >>>>             hoststr,
> >>>>             auth_b64);
> >>>>
> >>>>-    av_freep(&auth_b64);
> >>>>+    av_free(auth_b64);
> >>>
> >>>why?
> >>
> >>I don't know.  ;-)
> >>
> >>I allocate it with av_malloc, and have never seen av_freep(), so
> >>figured I would change it to something I knew would work right.
> >>
> >>I assume that av_freep() frees the memory that the pointer points to,
> >>but assumptions can get me in trouble...
> >
> >void av_freep(void**p) { av_free(*p); *p = NULL; }
> 
> I guess part of my thought process was why was it done this way.
> 
> But mine is not to wonder why, mine is just to patch or die.... ;-)

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is