[Ffmpeg-devel] [PATCH] FAAC profile selection
Fri Apr 27 22:55:10 CEST 2007
L'octidi 8 flor?al, an CCXV, Michael Niedermayer a ?crit?:
> first patch ok
> second patch not, the values used in AVOption should not be at the mercy of an
> external header that is xyz_profile should have the same value independant of
> what is in an external header or even if the external header is available at
> all IMHO
Thanks for your review.
Do you think it would be better to create FF_PROFILE_AAC_MAIN/... constants,
use them in utils.c, and have a case construct in faac.c to convert from
FF_* constants to faac.h constants?
By the way, I agree that the value of xyz_profile should not depend on an
external header. But on the other hand, it would be misleading if
AAC-related constants appear in the help message when ffmpeg is built
without an AAC encoder. Therefore, I believe that these constants should be
inside some sort of "#if HAVE_AN_AAC_ENCODER".
And since, as far as I know, libfaac is the only AAC encoder at this time,
CONFIG_LIBFAAC is as good a candidate as anything else to be
HAVE_AN_AAC_ENCODER; it would be soon enough to change that when another AAC
encoder will be available.
PS to the moderators: sorry for the messages from the wrong address; I am in
the process of changing my main address and my config is not perfect yet.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 185 bytes
Desc: Digital signature
More information about the ffmpeg-devel