[Ffmpeg-devel] [PATCH] FAAC profile selection

Michael Niedermayer michaelni
Sat Apr 28 20:53:26 CEST 2007


On Fri, Apr 27, 2007 at 10:55:10PM +0200, Nicolas George wrote:
> L'octidi 8 flor?al, an CCXV, Michael Niedermayer a ?crit?:
> > first patch ok
> > 
> > second patch not, the values used in AVOption should not be at the mercy of an
> > external header that is xyz_profile should have the same value independant of
> > what is in an external header or even if the external header is available at
> > all IMHO
> Thanks for your review.
> Do you think it would be better to create FF_PROFILE_AAC_MAIN/... constants,
> use them in utils.c, and have a case construct in faac.c to convert from
> FF_* constants to faac.h constants?


> By the way, I agree that the value of xyz_profile should not depend on an
> external header. But on the other hand, it would be misleading if
> AAC-related constants appear in the help message when ffmpeg is built
> without an AAC encoder. Therefore, I believe that these constants should be
> inside some sort of "#if HAVE_AN_AAC_ENCODER".

iam not disagreeing with your argumentation but i prefer the simplest/most
minimal code which gets the job done optimally and theres no real gain with
the #ifdef IMHO

also various other parts of AVOption are not under #ifdef
i mean arithmetic coding, the various mpeg4 options, ...
and if they all where under ifdefs the AVOption list would contain 3 times
more ifdefs then actual code ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070428/94946c54/attachment.pgp>

More information about the ffmpeg-devel mailing list