[FFmpeg-devel] [PATCH] Use correct printf format strings in seek_test
Sun Aug 12 22:42:30 CEST 2007
On Sun, 12 Aug 2007 14:44:20 -0400
David Conrad <umovimus at gmail.com> wrote:
> On Aug 12, 2007, at 7:53 AM, Diego Biurrun wrote:
> > On Sat, Aug 11, 2007 at 07:52:59PM -0400, David Conrad wrote:
> >> Seek regression tests currently fail on my PPC Mac OS X machine.
> >> Part of it
> >> is that the printf format strings aren't correct; %f is used for
> >> doubles
> >> and %Ld is used for int64_t. This patch fixes that.
> > Do regression tests work for you with this patch applied? They
> > fail for
> > me on PPC Linux.
> They still fail, but this seems to be due to a Mac OS X-specific
> issue. Specifically, the return value of av_read_frame() is a part of
> the regression tests but ffm.c returns EAGAIN in some cases. The
> problem is that EAGAIN is defined to 35 on Mac OS X and
> seek.regression.ref expects that it's defined as 11. I'm not sure
> what would be the preferred way of fixing this, maybe add EAGAIN as
> an AVERROR_ and have a function to convert AVERROR_* to a string to
> print that?
Having a function to convert AVERROR(*) to a string and using this
function in the seek test seems to be a good solution to me.
More information about the ffmpeg-devel