[FFmpeg-devel] [PATCH] Use correct printf format strings in seek_test

Michael Niedermayer michaelni
Mon Aug 13 00:45:55 CEST 2007


On Sun, Aug 12, 2007 at 02:44:20PM -0400, David Conrad wrote:
> On Aug 12, 2007, at 7:53 AM, Diego Biurrun wrote:
>> On Sat, Aug 11, 2007 at 07:52:59PM -0400, David Conrad wrote:
>>> Seek regression tests currently fail on my PPC Mac OS X machine. Part of 
>>> it
>>> is that the printf format strings aren't correct; %f is used for doubles
>>> and %Ld is used for int64_t. This patch fixes that.
>> Do regression tests work for you with this patch applied?  They fail for
>> me on PPC Linux.
> They still fail, but this seems to be due to a Mac OS X-specific issue. 
> Specifically, the return value of av_read_frame() is a part of the 
> regression tests but ffm.c returns EAGAIN in some cases. The problem is 
> that EAGAIN is defined to 35 on Mac OS X and seek.regression.ref expects 
> that it's defined as 11. I'm not sure what would be the preferred way of 
> fixing this, maybe add EAGAIN as an AVERROR_ and have a function to convert 
> AVERROR_* to a string to print that?

id say change seektest.c so it does:
if(ret == AVERROR(EAGAIN))
    printf("EAGAIN");  //or some more generic solution to tur the code in a string
    printf("%d", ret);

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070813/c4117d8d/attachment.pgp>

More information about the ffmpeg-devel mailing list