[FFmpeg-devel] [PATCH] fix clicking sound in xa-adpcm

Michael Niedermayer michaelni
Sun Dec 9 00:13:11 CET 2007

On Wed, Dec 05, 2007 at 11:32:53AM -0500, Alexander Strange wrote:
> The XA ADPCM decoder resets the last sample predictors to 0 after every 
> frame.
> This is wrong, and causes loud clicking constantly in all my samples. 
> Attached patch fixes it.

patch is probably ok

> I can't tell if seeking is affected, since the STR demuxer can't seek
> in ffplay (not sure why) and can't be remuxed (no codec_tag).

i think the str demuxer needs some cleanup work ...
hell there are even printf() in there ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071209/9bfefcb0/attachment.pgp>

More information about the ffmpeg-devel mailing list