[FFmpeg-devel] [PATCH] fix clicking sound in xa-adpcm

Alexander Strange astrange
Thu Dec 27 09:20:24 CET 2007


On Dec 8, 2007, at 6:13 PM, Michael Niedermayer wrote:

> On Wed, Dec 05, 2007 at 11:32:53AM -0500, Alexander Strange wrote:
>> The XA ADPCM decoder resets the last sample predictors to 0 after  
>> every
>> frame.
>> This is wrong, and causes loud clicking constantly in all my samples.
>> Attached patch fixes it.
>
> patch is probably ok

Ping; does anyone else have a problem with it?
I think it wouldn't be any worse than missing the bit reservoir in mp3,
in a perfect world where it could seek in this format in the first  
place.

I'm looking at a crash (will add a ticket after I wake up) and don't
want to have more than one patch against this floating around.




More information about the ffmpeg-devel mailing list