[FFmpeg-devel] [PATCH] truth value assignment warnings

Reimar Döffinger Reimar.Doeffinger
Mon Dec 17 18:49:41 CET 2007


Hello,
On Mon, Dec 17, 2007 at 12:04:33AM +0100, Diego Biurrun wrote:
> --- libavcodec/wmaenc.c	(revision 11244)
> +++ libavcodec/wmaenc.c	(working copy)
> @@ -178,7 +178,7 @@
>      }
>  
>      for(ch = 0; ch < s->nb_channels; ch++) {
> -        if (s->channel_coded[ch]= 1) { //FIXME
> +        if ((s->channel_coded[ch]= 1)) { //FIXME

This seems really ugly to me and the FIXME is a bit sparse on details...
Maybe someone could improve this a bit, if as I assume the "= 1" is the
hack that needs fixme it would better on an extra line that can be
easily commented-out for testing...

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list