[FFmpeg-devel] [PATCH] truth value assignment warnings

Michel Bardiaux mbardiaux
Mon Dec 17 19:13:03 CET 2007


Reimar D?ffinger a ?crit :
> Hello,
> On Mon, Dec 17, 2007 at 12:04:33AM +0100, Diego Biurrun wrote:
>> --- libavcodec/wmaenc.c	(revision 11244)
>> +++ libavcodec/wmaenc.c	(working copy)
>> @@ -178,7 +178,7 @@
>>      }
>>  
>>      for(ch = 0; ch < s->nb_channels; ch++) {
>> -        if (s->channel_coded[ch]= 1) { //FIXME
>> +        if ((s->channel_coded[ch]= 1)) { //FIXME
> 
> This seems really ugly to me and the FIXME is a bit sparse on details...
> Maybe someone could improve this a bit, if as I assume the "= 1" is the
> hack that needs fixme it would better on an extra line that can be
> easily commented-out for testing...
> 
Yes, it doesnt make much sense as it is, if the =1 is needed then why 
the if? Much better to leave the warning here!

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/




More information about the ffmpeg-devel mailing list