[FFmpeg-devel] [PATCH] rtsp - alternate protocol

Michael Niedermayer michaelni
Sat Dec 29 17:13:31 CET 2007

On Sat, Dec 29, 2007 at 12:19:12PM +0100, Luca Abeni wrote:
> Hi Michael,
> Michael Niedermayer wrote:
> [...]
>> heres a attempt to fix it (completely untested, theres a good chance it
>> contains trivial mistakes but ill comit it if noone points at a problem
>> soon *g*)
>> @@ -2941,7 +2941,7 @@
>>                 char *path, int path_size,
>>                 const char *url)
>>  {
>> -    const char *p, *ls, *at, *col, *brk, *q;
>> +    const char *p, *ls, *at, *col, *brk;
> I did some tests with various url_split() versions and with current svn + 
> your patch, and it seems to me that your patch fixes almost all the 
> testcases. I only found a case about which I am not sure: the URL 
> rtp://localhost?localport=5000 gives ?localport=5000 as path. I suspect 
> this is wrong (?localport=5000 should be the path for 
> rtp://localhost/?localport=5000, right?).

IIRC rich said '?' counts as host / path seperator if theres no '/' either way
ive commited my patch. We can always commit your interdiff if we find a case
where it causes problems.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071229/1fafcd52/attachment.pgp>

More information about the ffmpeg-devel mailing list